Adding decimal column type support and fixed bigint, mediumtext and longtext#3
Open
XeroXer wants to merge 4 commits intogwa:masterfrom
Open
Adding decimal column type support and fixed bigint, mediumtext and longtext#3XeroXer wants to merge 4 commits intogwa:masterfrom
XeroXer wants to merge 4 commits intogwa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for decimal column type. Tested this with all my current decimal column types with precision, scale and unsigned.
Found and fixed a bug with bigint columns getting MysqlAdapter::INT_BIG but not type integer, instead got [bigint].
Found and fixed the same kind of bug with mediumtext and longtext. They got the right MysqlAdapter constant but not the corrent column type.
Noticed host and port parameters looked to be handled incorrectly so tweaked that a bit.